Host sleep settings not putting system to sleep

Description

The sleep options under settings in the UIVM are not properly sleeping laptops. In addition, the sleep option under Power does not put the laptop to sleep

  • The sleep after X minutes setting will perform a system reboot after X minutes

  • The lid close options do not sleep the system or perform any other action

  • The sleep option under power will restart the system

Environment

OpenXT Stable 9 6524

Dell Latitude 7490
BIOS 1.8.0, TPM2, UEFI

Dell Latitude E7450 - Legacy BIOS

Validation Steps

  1. Install OpenXT Stable 9 Build 6524 UEFI or Legacy

Sleep settings

  1. Go to Settings -> sleep

  2. Enable "Put the entire system to sleep after X minutes"

  3. See if system sleeps or reboots after X minutes

When lid closes

  1. Go to Settings -> sleep

  2. Enable "Put the entire system to sleep"

  3. Close the lid, see if the system sleeps

Power Settings

  1. Select sleep under power

  2. See if system sleeps or restarts

Activity

Show:
Andrew Jones
May 1, 2019, 5:09 PM

As a temporary fix, could we consider greying out the sleep button and sleep options within the host? That would prevent use of them and encountering the bugs, should be a relatively lightweight change, and doesn't actually remove the features for when they eventually get patched.

Jed
May 6, 2019, 9:54 PM

PR up for the main sleep button and the sleep timeout options (upgrade not handled).

Next is the lid options.
Those obviously have to be grayed out in the UI, but also actually disabled...
The setting lives in /config/db, and originates from https://github.com/OpenXT/xenclient-oe/blob/master/recipes-openxt/dbd/dbd/db.default
Line 10 should probably be set to "nothing".

Now the upgrade...
Should we change both lid options to "nothing" on upgrade?
I'd say we should, or we could have a release note telling the user to disable all sleep-related options before upgrading.

Then, what about VMs?
For example, if a VM has "control-platform-power-state" set to true, should we ignore that when it goes to sleep?

There's probably more...

Chris Rogers
May 7, 2019, 1:37 PM
Edited

Looks like we'll need:

  • a migration rule to set the db options to "nothing"

  • to wire sleep/hibernate to do nothing for control-platform-power-state

  • Grey out lid options in UI

I think that's it though. I'd rather leave all the logic hooked up to be able to sleep to debug when we get around to supporting S3.

Rich Persaud
May 7, 2019, 2:51 PM

UI changes are ok.

If we are going to leave this feature intact via toolstack, then we don't need to modify config data processed by the toolstack.

If someone has this enabled on a device today, then it already works ok their device. No need to modify that user's working data. Everyone else will have already disabled it.

Trenchboot will hopefully enable OpenXT to reduce dependency on tboot and it's negative impact on sleep modes.

Nicholas Tsirakis
June 25, 2019, 3:58 PM

Confirming - the desired resolution for this ticket was to gray out the sleep options in both the Settings and via the Power button, correct? If so, that is the case on rc1. I am unable to verify the laptop lid options as I only have a desktop, so please reassign to somebody who can confirm this.

Fixed

Assignee

Nicholas Tsirakis

Reporter

Andrew Jones

Labels

None

QA Assignee

None

QA Image URL

None

Epic Link

Components

Fix versions

Affects versions

Priority

Major
Configure